Fix dropped positional argument for packages with multiple bins#21
Open
lazerg wants to merge 1 commit into
Open
Fix dropped positional argument for packages with multiple bins#21lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
Author
|
@joetannenbaum this one's ready whenever you get a chance — 1.x fix for the arg-parsing bug in #15. |
Collaborator
|
Thanks for the PR! Right now we're focusing entirely on v2.x, so I'm going to hold off on this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For packages with more than one bin, the first positional argument was always dropped because
$console->arguments[0] ?? null === $possibleCommandis parsed as$console->arguments[0] ?? (null === $possibleCommand)(===binds tighter than??), so the guard unset the argument whenever one was present. Wrapping the?? nullin parentheses fixes it. For example,cpx brianium/paratest tests/Subnow runs justtests/Subinstead of the whole suite.Fixes #15